<html>
<head><meta charset="utf-8"><title>clap-rs incr build times · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/clap-rs.20incr.20build.20times.html">clap-rs incr build times</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="218337160"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/clap-rs%20incr%20build%20times/near/218337160" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/clap-rs.20incr.20build.20times.html#218337160">(Nov 30 2020 at 19:57)</a>:</h4>
<p>Anyone know of what might have been impacted that resulted in <a href="https://perf.rust-lang.org/compare.html?start=28b86e0860f0593b85cda6c2c7b03ae8a582962f&amp;end=f76f72250e36c9ad4eb3bd3f08770228cc07da6c">only clap-rs incremental build times to go up</a> such significantly</p>



<a name="218337596"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/clap-rs%20incr%20build%20times/near/218337596" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/clap-rs.20incr.20build.20times.html#218337596">(Nov 30 2020 at 20:00)</a>:</h4>
<p>My guess is something in that PR is adding a new dependency to incr tracking</p>



<a name="218337661"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/clap-rs%20incr%20build%20times/near/218337661" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/clap-rs.20incr.20build.20times.html#218337661">(Nov 30 2020 at 20:00)</a>:</h4>
<p>hm, actually, the query execution count didn't change, odd</p>



<a name="218338045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/clap-rs%20incr%20build%20times/near/218338045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/clap-rs.20incr.20build.20times.html#218338045">(Nov 30 2020 at 20:03)</a>:</h4>
<p>My guess is that we'll need to cachegrind  diff to determine</p>



<a name="218338360"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/clap-rs%20incr%20build%20times/near/218338360" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/clap-rs.20incr.20build.20times.html#218338360">(Nov 30 2020 at 20:05)</a>:</h4>
<p>The PR adds an extra structure to TypeckResults, maybe that?</p>



<a name="218338761"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/clap-rs%20incr%20build%20times/near/218338761" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/clap-rs.20incr.20build.20times.html#218338761">(Nov 30 2020 at 20:08)</a>:</h4>
<p>Possible.</p>



<a name="218338792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/clap-rs%20incr%20build%20times/near/218338792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/clap-rs.20incr.20build.20times.html#218338792">(Nov 30 2020 at 20:09)</a>:</h4>
<p>FWIW I would not worry too much, a 4% hit on incr is not problematic at all.</p>



<a name="218338835"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/clap-rs%20incr%20build%20times/near/218338835" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aman Arora <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/clap-rs.20incr.20build.20times.html#218338835">(Nov 30 2020 at 20:09)</a>:</h4>
<p>thank you <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>